Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add doc for require_all_on #263

Merged
merged 6 commits into from
Oct 2, 2023
Merged

add doc for require_all_on #263

merged 6 commits into from
Oct 2, 2023

Conversation

juliettelavoie
Copy link
Contributor

@juliettelavoie juliettelavoie commented Sep 29, 2023 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • HISTORY.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • added info on require_all_on in the doc string.

Does this PR introduce a breaking change?

no

Other information:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added the docs label Sep 29, 2023
@juliettelavoie juliettelavoie changed the title add doc add doc for require_all_on Sep 29, 2023
RondeauG
RondeauG approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@RondeauG RondeauG left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/notebooks/1_catalog.ipynb Outdated Show resolved Hide resolved
docs/notebooks/1_catalog.ipynb Outdated Show resolved Hide resolved
xscen/extract.py Outdated Show resolved Hide resolved
@juliettelavoie juliettelavoie merged commit 1fcb240 into main Oct 2, 2023
6 checks passed
@juliettelavoie juliettelavoie deleted the require_all_on_doc branch October 2, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RondeauG RondeauG RondeauG approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliettelavoie @RondeauG